Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bootstrap base and docker #14784

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

BenTheElder
Copy link
Member

  • debian buster has been the stable debian since ~july
  • docker 18.06 was last patched in february, 19.03.X is the current stable docker and has seen very recent patches for security fixes (amongst other things)

there's a lot of fixes in docker in particular, however we should keep an eye on the upgrade for other deps (gcloud?)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2019
@aojea
Copy link
Member

aojea commented Oct 15, 2019

/hold
docker 19.03.3 has a known issue and 19.03.4 was not released yet

https://github.com/docker/docker-ce/releases

maybe we can pin to 19.03.2?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2019
@BenTheElder
Copy link
Member Author

docker 19.03.3 has a known issue and 19.03.4 was not released yet

can you elaborate? docker 18.06 also has known issues...

@aojea
Copy link
Member

aojea commented Oct 15, 2019

ups, well, maybe is not impacting us, sorry

DOCKER-USER iptables chain is missing docker/for-linux#810. Users cannot perform additional container network traffic filtering on top of this iptables chain. You are not affected by this issue if you are not customizing iptables chains on top of DOCKER-USER.

@BenTheElder
Copy link
Member Author

we're not customizing those

if we do start at some point (hopefully we don't!) we could apply the known workaround in runner.sh anyhow though.

@aojea
Copy link
Member

aojea commented Oct 15, 2019

/hold cancel
/lgtm

sorry for the noise

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 70267a4 into kubernetes:master Oct 15, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 15, 2019
@BenTheElder BenTheElder deleted the upgrade-base-image branch October 15, 2019 20:50
@hakman
Copy link
Member

hakman commented Nov 4, 2019

Hi @BenTheElder. Does this change mean that future patch releases for k8s 1.14-1.16 will also be tested & validated with Docker 19.03?

@BenTheElder
Copy link
Member Author

@hakman no, it does not. this docker is used for image building etc. NOT on the nodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants