-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bootstrap base and docker #14784
Upgrade bootstrap base and docker #14784
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold https://github.com/docker/docker-ce/releases maybe we can pin to 19.03.2? |
can you elaborate? docker 18.06 also has known issues... |
ups, well, maybe is not impacting us, sorry
|
we're not customizing those if we do start at some point (hopefully we don't!) we could apply the known workaround in runner.sh anyhow though. |
/hold cancel sorry for the noise |
Hi @BenTheElder. Does this change mean that future patch releases for k8s 1.14-1.16 will also be tested & validated with Docker 19.03? |
@hakman no, it does not. this docker is used for image building etc. NOT on the nodes |
there's a lot of fixes in docker in particular, however we should keep an eye on the upgrade for other deps (gcloud?)