Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump bootstrap to gcr.io/k8s-testimages/bootstrap:v20191015-70267a4 #14787

Merged
merged 1 commit into from
Oct 16, 2019
Merged

bump bootstrap to gcr.io/k8s-testimages/bootstrap:v20191015-70267a4 #14787

merged 1 commit into from
Oct 16, 2019

Conversation

BenTheElder
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/images area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 15, 2019
@BenTheElder
Copy link
Member Author

/assign @fejta

hoping this will pick up some docker improvements in particular. (or rather, will once we bump kubekins next...)

@fejta
Copy link
Contributor

fejta commented Oct 16, 2019

/assign @Katharine
shouldn't the autobumper figure this out? Or is this another instance of the "/" bug?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 16, 2019
fejta
fejta approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta
Copy link
Contributor

fejta commented Oct 16, 2019

/cc @michelle192837
FYI

@BenTheElder
Copy link
Member Author

shouldn't the autobumper figure this out? Or is this another instance of the "/" bug?

I think the autobumper doesn't handle Dockerfiles in particular? most of our files are FROM <third party image> but in this case we have a FROM <our image> in another image.

I just went ahead and bumped the other references as well, not sure if they would be auto bumped otherwise.

@Katharine
Copy link
Member

The autobumper only checks yaml files.

@Katharine
Copy link
Member

I'm not sure why the yaml files didn't get updated, though…

@BenTheElder
Copy link
Member Author

spoke to michelle
/hold cancel
🤞

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 64c95ff into kubernetes:master Oct 16, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 16, 2019
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default using the following files:

  • key cadvisor.yaml using file config/jobs/cadvisor/cadvisor.yaml
  • key kubernetes-builds.yaml using file config/jobs/kubernetes/sig-release/kubernetes-builds.yaml
  • key 1.13.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.13.yaml
  • key 1.14.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.14.yaml
  • key 1.15.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.15.yaml
  • key 1.16.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
  • key shadow-builds.yaml using file config/jobs/kubernetes/sig-release/shadow-builds.yaml
  • key integration.yaml using file config/jobs/kubernetes/sig-testing/integration.yaml
  • key verify.yaml using file config/jobs/kubernetes/sig-testing/verify.yaml

In response to this:

version from https://storage.googleapis.com/kubernetes-jenkins/logs/post-test-infra-push-bootstrap/1184210031193624576/artifacts/build.log (most recent post-test-infra-push-bootstrap)

ref: #14784

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@chases2 chases2 Awaiting requested review from chases2

@dashpole dashpole Awaiting requested review from dashpole

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@Katharine Katharine

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @fejta @k8s-ci-robot @Katharine