Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tekton v1beta1 client #27032

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

eddycharly
Copy link
Member

This PR adds tekton v1beta1 client.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 4, 2022
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
@eddycharly
Copy link
Member Author

@alvaroaleman this adds support for generating tekton client v1beta1. I'd like to give a try to supporting both v1alpha1 and v1beta1 side by side.

@eddycharly
Copy link
Member Author

/test pull-test-infra-integration

2 similar comments
@eddycharly
Copy link
Member Author

/test pull-test-infra-integration

@eddycharly
Copy link
Member Author

/test pull-test-infra-integration

@eddycharly
Copy link
Member Author

/assign @spiffxp

@eddycharly
Copy link
Member Author

@alvaroaleman can we merge this one ?

@qaifshaikh
Copy link

Can we get some help to merge this @cjwagner?

@qaifshaikh
Copy link

@spiffxp can you help out here?

@stevekuznetsov
Copy link
Contributor

Sorry if I'm missing something, but why are we generating the tekton clients here (as opposed to importing them)?

@eddycharly
Copy link
Member Author

@stevekuznetsov see #27018

@stevekuznetsov
Copy link
Contributor

Ah, yes, now I remember. Thank you :)

/lgtm
/approve

Let's get this in, then

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddycharly, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 78036aa into kubernetes:master Aug 26, 2022
@eddycharly
Copy link
Member Author

Thanks @stevekuznetsov !

@eddycharly eddycharly deleted the tekton-beta branch August 26, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants