-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing kubectl generated docs links #10081
Comments
Agreed. 💯
It looks like Totally out of scope: I'm annoyed that Hugo doesn't let us link directly to external URLs from the TOC, and requires us instead to have @steveperry-53 @chenopis @Bradamant3 @zparnold 👋 What do you think? |
Thanks for your input @zacharysarah! My understanding is that I just want to make sure we're on the same page that this change would require removing it from the doc generation process (specifically by removing these lines here: https://github.com/kubernetes/website/blob/master/update-imported-docs/reference.yml#L19-L20) @steveperry-53 I'm particularly interested in your thoughts since I found a discussion on the mailing list where you suggested something else: https://groups.google.com/forum/#!topic/kubernetes-sig-docs/ZMVVNBu2TD8 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I've been looking into fixing the broken links on this page that have been mentioned in a few issues.
Looks like the cause of this is that
update-imported-docs/reference.yml
doesn't import all the files generated fromhack/generate-docs.sh
in k/k. So one possible fix is just adding those files toreference.yml
.However, all of that information is also generated and imported by https://github.com/kubernetes-incubator/reference-docs and is available here: https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands
We probably don't want to kubectl docs duplicated like that. Should we just replace the https://kubernetes.io/docs/reference/kubectl/kubectl/ page with a static md file that links to https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands? Or totally replace that page?
Would love to hear your thoughts/suggestions for the best way to fix this.
The text was updated successfully, but these errors were encountered: