change URL to kubectl commands #10145
Conversation
k8s-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 40f55ba https://deploy-preview-10145--kubernetes-io-master-staging.netlify.com |
1 similar comment
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 40f55ba https://deploy-preview-10145--kubernetes-io-master-staging.netlify.com |
|
/assign @steveperry-53 |
xiangpengzhao
requested review from
steveperry-53 and
mdlinville
and removed request for
xiangpengzhao
| * [kubectl uncordon](kubectl_uncordon.md) - Mark node as schedulable | ||
| * [kubectl version](kubectl_version.md) - Print the client and server version information | ||
| * [kubectl wait](kubectl_wait.md) - Experimental: Wait for one condition on one or many resources | ||
| * [kubectl alpha](https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#alpha) - Commands for features in alpha |
There was a problem hiding this comment.
@zembutsu Please remove the domain portion from all of these. They should all start with /docs/. Thanks!
|
/hold Thanks for the PR. Please address the feedback so we can get this in. 👍 |
k8s-ci-robot
added
the
do-not-merge/hold
|
@MistyHacks, not sure if you've seen it, but there is some discussion going on about this in #10081 regarding what'd be the right approach (cc: @tfogo @zacharysarah) |
|
It looks like #9081 might take some time to get merged. So I think implementing a stopgap measure such as this is a good idea. One thing to be aware of is @tengqm, what are your thoughts? |
|
Yeah, I didn't notice that the changes were to a generated file. You need to either change the template used to generate the file (which @tengqm and @steveperry-53 are experienced with) or if the problem is with the code the generation scripts use, you need to commit the fix to that code itself. In this case it looks like there are problems with the assumption the generation script is making. At any rate, the approach in this PR won't work and I'll close it for now. @zembutsu, please open a new PR if you want to propose a change to the generation script or to the underlying code the script uses. |
FIx #10131
At this time, there are no .md pages corresponding to each commands.
Therefore, I added a reference page anchor.