-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): adding event emitter #2269
Conversation
47af86d
to
96ad075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean job @danielbdias I like how you moved the main facade function to a diff file
PoolingMaxWaitTimeForTraceDuration() time.Duration | ||
} | ||
|
||
func newRunnerFacades( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved to ./server/app/facade.go
to keep all concerns about the façade there.
} | ||
} | ||
|
||
func (em *internalEventEmitter) Emit(ctx context.Context, event model.TestRunEvent) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the next PRs we can evolve this method to also manage/start trace spans with each phase that we designed.
This PR aims to create an Event Emitter structure inside
./server/executor
that allows us to emit and persist events on Tracetest Server.Changes
Fixes
Checklist