Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions to build and upload #20

Merged
merged 28 commits into from
Feb 20, 2023

Conversation

kxc-wraikny
Copy link
Contributor

@kxc-wraikny kxc-wraikny commented Feb 16, 2023

resolve #13

subtask

  • build docker image on GitHub Actions
    • for linux/amd64
    • for linux/arm64
  • Cache
  • set node version
  • matrix build
  • push to ghcr

references

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@haochenx haochenx marked this pull request as ready for review February 17, 2023 21:13
@haochenx haochenx marked this pull request as draft February 17, 2023 21:13
@haochenx
Copy link
Member

fyi: @kxc-waddlaw @kxc-wraikny
すみません、間違えて一度 ready for review にしてしまって、 draft に戻しました 🙏

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@haochenx haochenx force-pushed the add-github-actions-to-build-and-upload branch 2 times, most recently from 568b18b to 2f05e56 Compare February 18, 2023 17:48
@haochenx haochenx force-pushed the add-github-actions-to-build-and-upload branch from 2f05e56 to 1f0c74b Compare February 18, 2023 17:53
@haochenx haochenx marked this pull request as ready for review February 18, 2023 18:13
@haochenx haochenx force-pushed the add-github-actions-to-build-and-upload branch from 2ff081e to 40fffcd Compare February 18, 2023 18:30
@haochenx
Copy link
Member

(あれ、一昨日もろもろ push したあとのコメントが GitHub に食べられてしまったっぽい..)

(fyi: @kxc-waddlaw @kxc-wraikny )
私にとって mergeable になるように、もろもろ変更加えました。
GHCR への push は main にマージされた時点のみにしてありますので、その動作確認は一旦マージすることでみましょう。
@kxc-wraikny 変更点確認して頂いて気になる点がありましたら修正/コメントお願いします。
@kxc-waddlaw レビューしてもらって問題ないようでしたらマージしましょう。

Copy link
Collaborator

@kxc-waddlaw kxc-waddlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +121 to +124
key: ${{ runner.os }}-buildx-${{ matrix.arch }}-${{ env.DOCKER_TAG }}-${{ github.sha }}
restore-keys: |
${{ runner.os }}-buildx-${{ matrix.arch }}-${{ env.DOCKER_TAG }}
${{ runner.os }}-buildx-${{ matrix.arch }}-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

キャッシュのキーの prefix に v1- とか付けた方がよいです。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use GitHub Actions to build and upload docker images
3 participants