Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 5.0.0 compatibility #19

Closed
kxc-waddlaw opened this issue Feb 15, 2023 · 4 comments · Fixed by #27
Closed

OCaml 5.0.0 compatibility #19

kxc-waddlaw opened this issue Feb 15, 2023 · 4 comments · Fixed by #27
Assignees

Comments

@kxc-waddlaw
Copy link
Collaborator

kxc-waddlaw commented Feb 15, 2023

The current Dockerfile approach requires two Dockerfiles, one for OCaml 4 and one for OCaml 5. (for installing dependencies. See: https://github.com/kxcteam/pubinfra.dockerfiles/pull/17/files)

Therefore, we want to use Docker's "ARG" feature to externally provide OCaml version information and switch installation scripts accordingly. (ref: Understand how ARG and FROM interact and ARG)

example:

$ docker build --build-arg package_install_script_filename=install_ocaml_4_pacakges.sh .
# In this case, we expect that `install_ocaml_4_pacakges.sh` will be called internally.


$ docker build --build-arg package_install_script_filename=install_ocaml_5_pacakges.sh .
# In this case, we expect that `install_ocaml_5_pacakges.sh` will be called internally.
@haochenx haochenx assigned haochenx and kxc-wraikny and unassigned haochenx Feb 16, 2023
@kxc-wraikny
Copy link
Contributor

Would it be good to start this issue ( #19 ) after #17 is merged and then continue with #13?

@haochenx
Copy link
Member

@kxc-wraikny #13 is way more important than #19 so please proceed from #13 first

@haochenx
Copy link
Member

@kxc-wraikny
この PR やる時 ↓ PR で追加された GitHub Actions の workflow の validate-ocaml-general ジョブの matrix に ocaml-version = 5.0.0 をいれてほしい

@haochenx
Copy link
Member

fyi: @kxc-wraikny @kxc-waddlaw
desc にあった build-arg を変更しました

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants