Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OCaml 5.0.0 compatibility #27

Merged
merged 8 commits into from
Feb 21, 2023
Merged

add OCaml 5.0.0 compatibility #27

merged 8 commits into from
Feb 21, 2023

Conversation

kxc-wraikny
Copy link
Contributor

@kxc-wraikny kxc-wraikny commented Feb 21, 2023

resolve #19

  • add script files to /ocaml-general/install_ocaml_*_packages.sh.
  • update /ocaml-general/Dockerfile to use above install script files.
  • enable ocaml-version 5.0.0 in /.github/workflows/ocaml-general.yml.
  • operation check
  • question: Should js_of_ocaml-lwt.4.1.0 be installed with OCaml 4 as well?

@kxc-wraikny kxc-wraikny force-pushed the ocaml-5-compatibility branch from 0f9989d to 07bf944 Compare February 21, 2023 02:52
@kxc-wraikny kxc-wraikny changed the title add OCaml 5.0.0 compativility add OCaml 5.0.0 compatibility Feb 21, 2023
ocaml-general/Dockerfile Outdated Show resolved Hide resolved
ocaml-general/install_ocaml_5_packages.sh Outdated Show resolved Hide resolved
.github/workflows/ocaml-general.yml Outdated Show resolved Hide resolved
ocaml-general/Dockerfile Outdated Show resolved Hide resolved
@kxc-wraikny kxc-wraikny requested a review from haochenx February 21, 2023 08:24
Copy link
Member

@haochenx haochenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge!

@haochenx haochenx enabled auto-merge February 21, 2023 08:27
@haochenx haochenx added this pull request to the merge queue Feb 21, 2023
@haochenx haochenx removed this pull request from the merge queue due to a manual request Feb 21, 2023
@haochenx haochenx merged commit 3707a1b into main Feb 21, 2023
@haochenx haochenx deleted the ocaml-5-compatibility branch February 21, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCaml 5.0.0 compatibility
2 participants