Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BA-604): Add image_node and vfolder_node fields to ComputeSession schema #2987

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Oct 28, 2024

resolves #3532 (BA-604)

compute_session_nodes example

query ComputeSession {
    compute_session_nodes(
        scope_id: "project:2de2b969-1d04-48a6-af16-0bc8adb3c831",
    ) {
        edges {
            cursor
            node {
                id
                row_id
                name
                image_references
                vfolder_nodes {
                    edges {
                        node {
                            id
                            row_id
                            name
                            permissions
                        }
                    }
                }
                kernel_nodes {
                    edges {
                        node {
                            id
                            row_id
                            image {
                                id
                                row_id
                                name
                            }
                        }
                    }
                }
            }
        }
        count
        pageInfo {
            hasNextPage
            hasPreviousPage
        }
    }
}

compute_session_node example

query Session {
    compute_session_node(
        id: "<GLOBAL_ID>",
    ) {
        row_id
        name
        status
        vfolder_nodes {
            edges {
                node {
                    id
                    row_id
                    name
                }
            }
        }
        kernel_nodes {
            edges {
                node {
                    id
                    row_id
                }
            }
        }
    }
}

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

📚 Documentation preview 📚: https://sorna--2987.org.readthedocs.build/en/2987/


📚 Documentation preview 📚: https://sorna-ko--2987.org.readthedocs.build/ko/2987/

@fregataa fregataa added this to the 24.12 milestone Oct 28, 2024
@fregataa fregataa requested a review from yomybaby October 28, 2024 05:59
@fregataa fregataa self-assigned this Oct 28, 2024
@github-actions github-actions bot added comp:manager Related to Manager component size:L 100~500 LoC labels Oct 28, 2024
@fregataa fregataa marked this pull request as ready for review October 28, 2024 06:18
src/ai/backend/manager/models/gql_models/session.py Outdated Show resolved Hide resolved
src/ai/backend/manager/models/gql_models/session.py Outdated Show resolved Hide resolved
src/ai/backend/manager/models/gql_models/session.py Outdated Show resolved Hide resolved
@fregataa fregataa force-pushed the feat/add-image-node-and-vfolder-node-to-compute-session branch from f3c8d38 to 3aab734 Compare October 29, 2024 05:15
@fregataa fregataa changed the base branch from main to topic/10-29-fix_set_strict_join_condition_between_kernels_and_images October 29, 2024 05:15
Copy link
Member Author

fregataa commented Oct 29, 2024

Base automatically changed from topic/10-29-fix_set_strict_join_condition_between_kernels_and_images to main October 29, 2024 05:31
@fregataa fregataa force-pushed the feat/add-image-node-and-vfolder-node-to-compute-session branch 2 times, most recently from b7cab00 to a1bf3e5 Compare October 29, 2024 07:57
@fregataa fregataa requested a review from yomybaby October 29, 2024 07:57
@fregataa fregataa force-pushed the feat/add-image-node-and-vfolder-node-to-compute-session branch from f5cc7fc to 96883da Compare October 29, 2024 09:22
@fregataa fregataa added this pull request to the merge queue Oct 29, 2024
@fregataa fregataa removed this pull request from the merge queue due to a manual request Oct 29, 2024
@fregataa fregataa force-pushed the feat/add-image-node-and-vfolder-node-to-compute-session branch 4 times, most recently from 311fa3f to be01b27 Compare October 31, 2024 02:04
@fregataa fregataa force-pushed the feat/add-image-node-and-vfolder-node-to-compute-session branch 2 times, most recently from 448b768 to 737f7f5 Compare November 7, 2024 12:06
@fregataa fregataa changed the base branch from main to topic/11-07-refactor_add_image_batch_loader_function November 7, 2024 12:06
Base automatically changed from topic/11-07-refactor_add_image_batch_loader_function to main November 7, 2024 12:20
@fregataa fregataa force-pushed the feat/add-image-node-and-vfolder-node-to-compute-session branch from c100bfa to 03b7bee Compare November 13, 2024 09:21
@HyeockJinKim
Copy link
Collaborator

check ci lol @fregataa

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve a conflict.

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the conflicts? This PR needs to be merged for the Session list NEO. 😀 @fregataa

@github-actions github-actions bot added the area:docs Documentations label Jan 15, 2025
Copy link

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the conflicts? :)

@fregataa fregataa requested a review from ironAiken2 January 23, 2025 06:57
@fregataa fregataa modified the milestones: 24.12, 25Q1 Jan 23, 2025
@fregataa fregataa changed the title feat: Add image_node and vfolder_node fields to ComputeSession schema feat(BA-604): Add image_node and vfolder_node fields to ComputeSession schema Jan 23, 2025
@fregataa fregataa force-pushed the feat/add-image-node-and-vfolder-node-to-compute-session branch from e3bd039 to 3f5a13e Compare January 24, 2025 05:58
@fregataa fregataa requested a review from ironAiken2 January 24, 2025 06:23
@fregataa fregataa force-pushed the feat/add-image-node-and-vfolder-node-to-compute-session branch from 3f5a13e to 489e4ec Compare January 24, 2025 06:53
Copy link

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I �got an error.

ADMIN.GQL Exception: {'message': "'UUID' object has no attribute 'vfid'", 'locations': [{'line': 24, 'column': 5}], 'path': ['session', 'vfolder_nodes']}

Copy link

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image_node and vfolder_node fields to ComputeSessionNode type schema
4 participants