fix: Strengthen join condition between kernels and images #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
comp:manager
2 tasks
fregataa
changed the title
fregataa
deleted the
topic/10-29-fix_set_strict_join_condition_between_kernels_and_images
branch
lablup-octodog
pushed a commit
that referenced
this pull request
Oct 29, 2024
Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 2993
lablup-octodog
pushed a commit
that referenced
this pull request
Oct 29, 2024
Backported-from: main (24.12) Backported-to: 24.03 Backport-of: 2993
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
) Co-authored-by: Sanghun Lee <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
) Co-authored-by: Sanghun Lee <[email protected]>
6 tasks
agatha197
added a commit
to lablup/backend.ai-webui
that referenced
this pull request
Nov 5, 2024
related PR: lablup/backend.ai#2939 # Extended Image Information Support This PR adds support for extended image information in the ImageList component and related translations. It introduces new fields and modifies the display of image details when the backend supports the 'extended-image-info' feature. **Checklist:** - [ ] Minimum required manager version: 24.09.1 ## Changes 1. Updated `ImageListQuery` to include new fields: `namespace`, `base_image_name`, `tags`, and `version`. 2. Modified the ImageList component to conditionally render columns based on the `supportExtendedImageInfo` flag. 3. Added new translations for "Base image name" and "Tags" in multiple languages. 4. Updated the backend client to support the 'extended-image-info' feature for manager version 24.09.1 and above. ## Impact - Users will see more detailed image information when using a compatible backend version. - The image list will display new columns for base image name and tags when supported. - Existing functionality is preserved for older backend versions. ## Review Notes - Verify that the image list displays correctly with both old and new backend versions. - Check that new translations are applied correctly in different languages. - Ensure that sorting and filtering work properly with the new fields. ## How to test 1. Checkout core branch to `topic/10-22-feature_add_info_field_to_gql_image_schema` lablup/backend.ai#2993 2. Go to Environment page. ## What to check: - [ ] Check the data is valid. - [ ] Since 24.09.1: Full image path, Registry, Architecture, Namespace, Base image name, Version, Tags, Digest, Resource limit, Control. - [ ] Before 24.09.1: Full image path, Registry, Architecture, Name, Language, Version, Base, Constraints, Digest, Resource limit, Control. - [ ] All data is highlightable by searching images. - [ ] Sortable data works fine. ## Screenshots 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
KernelRow.image_rowrequires a join onkernels.imageandimages.namecolumn which is not unique.e.g. multiarch images may have multiple records with the same name value and in different architecture values.
Let's apply a strict join condition by check
architecturecolumnChecklist: (if applicable)