Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for composer 2.0 #3

Merged

Conversation

boesing
Copy link
Member

@boesing boesing commented Jun 10, 2020

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

Initial support for composer v2

@boesing boesing linked an issue Jun 10, 2020 that may be closed by this pull request
@boesing boesing added the Enhancement New feature or request label Jun 10, 2020
@boesing boesing requested a review from samsonasik June 10, 2020 15:14
@weierophinney
Copy link
Contributor

Do we need any additional jobs for Travis to test this, or will this be enough?

@boesing
Copy link
Member Author

boesing commented Jun 10, 2020

@weierophinney Functionality is untouched, I dont think that we need additional travis tests.
We are checking for lowest and latest dependencies which should be enough.

EDIT: Okay, we have to touch functionality...

@boesing boesing marked this pull request as draft June 10, 2020 15:47
@boesing boesing mentioned this pull request Jun 10, 2020
@boesing
Copy link
Member Author

boesing commented Jun 10, 2020

This PR would pass CI after merging #5
If we do not want to merge #5, I'll re-write the unit tests in here to support new composer v2 methods.

@boesing boesing added this to the 1.3.0 milestone Jun 13, 2020
boesing added 2 commits July 1, 2020 14:20
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
@weierophinney weierophinney force-pushed the feature/composer-2.0 branch from 8eec324 to 8da99d6 Compare July 1, 2020 19:20
@boesing boesing marked this pull request as ready for review July 1, 2020 19:21
@weierophinney weierophinney merged commit 8da99d6 into laminas-api-tools:develop Jul 1, 2020
@snapshotpl
Copy link
Member

After composer update I have downloaded released versions with this change and it's raise an error:

Fatal error: Uncaught TypeError: Argument 1 passed to Laminas\ApiTools\AssetManager\AssetInstaller::__invoke() must implement interface Composer\Package\PackageInterface, instance of Composer\Installer\PackageEvent given, called in /var/www/vendor/laminas-api-tools/api-tools-asset-manager/src/Plugin.php on line 109 and defined in /var/www/vendor/laminas-api-tools/api-tools-asset-manager/src/AssetInstaller.php:61
Stack trace:
#0 /var/www/vendor/laminas-api-tools/api-tools-asset-manager/src/Plugin.php(109): Laminas\ApiTools\AssetManager\AssetInstaller->__invoke(Object(Composer\Installer\PackageEvent))
#1 /var/www/vendor/laminas-api-tools/api-tools-asset-manager/src/Plugin.php(74): Laminas\ApiTools\AssetManager\Plugin->Laminas\ApiTools\AssetManager\{closure}()
#2 [internal function]: Laminas\ApiTools\AssetManager\Plugin->onPostAutoloadDump(Object(Composer\Script\Event))
#3 phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php(164): call_user_func(Array, Object(Composer\Script\Event))
#4 phar:///usr/ in /var/www/vendor/laminas-api-tools/api-tools-asset-manager/src/AssetInstaller.php on line 61

I'm using composer 1.10.7

@boesing boesing deleted the feature/composer-2.0 branch July 1, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adds support for Composer v2
3 participants