Simplify composer-plugin #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
|
Functionality is the same as before. As I dont think that anyone will ever extend services from composer plugins, I think we can safely create a new major version and let users upgrade. If we are doing this, we could target the composer v2 support to the next major aswell and we are ready for composer v2. If we do not want to do this, I will create the tests based on the composer version in #3 and we are ready for composer v2 aswell. |
Merged
|
For plugins, the only BC break really is if the functionality changes for the end-user consumer of the plugin; the API in this case is how it is consumed, not how it is coded. As such, I think we could likely target a new minor release, as we'd be bumping the Composer and/or PHP requirements only. |
Signed-off-by: Maximilian Bösing <[email protected]>
weierophinney
requested changes
Jul 1, 2020
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the complexity level which is needed to migrate to composer v2 in #3, I would like to propose this simplified version of this plugin.
It does the same as before. Due to the removal of the hole
PackageEventstuff, we do not have to create composer version specific unit tests in #3 and so on.What do you think?