Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CollectionLinkHydrator extends wrong base class when DoctrineModule > v3 is used #13

Open
zluiten opened this issue Jan 15, 2021 · 0 comments · May be fixed by #14
Open

CollectionLinkHydrator extends wrong base class when DoctrineModule > v3 is used #13

zluiten opened this issue Jan 15, 2021 · 0 comments · May be fixed by #14
Labels
Bug Something isn't working

Comments

@zluiten
Copy link
Contributor

zluiten commented Jan 15, 2021

Bug Report

Q A
Version(s) 1.9.*

Summary

Class Laminas\ApiTools\Doctrine\QueryBuilder\Hydrator\Strategy\CollectionLinkHydratorV3 should extend class AbstractCollectionStrategy of doctrine/doctrine-laminas-hydrator when DoctrineModule >v3 is installed, instead of the then removed AbstractCollectionStrategy of DoctrineModule v2.

DoctrineModule >v3 depends on doctrine/doctrine-laminas-hydrator so that library will be available.

Current behavior

Class Laminas\ApiTools\Doctrine\QueryBuilder\Hydrator\Strategy\CollectionLinkHydratorV3 extends the wrong base class.

How to reproduce

Just observe

Expected behavior

Class Laminas\ApiTools\Doctrine\QueryBuilder\Hydrator\Strategy\CollectionLinkHydratorV3 extends the AbstractCollectionStrategy of doctrine/doctrine-laminas-hydrator.
@zluiten zluiten added the Bug Something isn't working label Jan 15, 2021
@zluiten zluiten linked a pull request Jan 15, 2021 that will close this issue
Open
@froschdesign froschdesign linked a pull request Aug 16, 2021 that will close this issue
CollectionLinkHydrator should extend from different AbstractCollectionStrategy #14
Open
tasselchof added a commit to orderadmin/api-tools-doctrine-querybuilder that referenced this issue Oct 4, 2021
@tasselchof
laminas-api-tools#13 Updated base class.
561b6c9
tasselchof added a commit to orderadmin/api-tools-doctrine-querybuilder that referenced this issue Oct 4, 2021
@tasselchof
laminas-api-tools#13 Updated base class.
471a00b
@tasselchof tasselchof mentioned this issue Jan 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@zluiten