Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ^4.0 version of laminas-hydrator, dropped old dependency #23

Open
wants to merge 9 commits into
base: 1.10.x
Choose a base branch
from

Conversation

tasselchof
Copy link

Fixed issues #13 and #22.

@Ocramius Ocramius added the Enhancement New feature or request label Jan 29, 2022
@Ocramius Ocramius added this to the 1.10.0 milestone Jan 29, 2022
…doctrine/doctrine-module bumped to ^4.1.0 only.
@Ocramius
Copy link
Member

Seems like everything is failing.

Few things to fix:

  1. PR title
  2. Build failures (tests, static analysis)

@tasselchof
Copy link
Author

tasselchof commented Jan 29, 2022

@Ocramius I bumped into phpro/zf-doctrine-hydration-module problem and this module is abandoned.

Problem 1
    - laminas-api-tools/api-tools-doctrine[2.1.0, ..., 2.2.1] require phpro/zf-doctrine-hydration-module ^2.0.1 || ^3.0 -> satisfiable by phpro/zf-doctrine-hydration-module[v2.0.1, v3.0.0].
    - laminas-api-tools/api-tools-doctrine[2.3.0, ..., 2.4.0] require phpro/zf-doctrine-hydration-module ^2.0.1 || ^3.0 || ^4.1 -> satisfiable by phpro/zf-doctrine-hydration-module[v2.0.1, v3.0.0, v4.1.0].
    - phpro/zf-doctrine-hydration-module v2.0.1 requires doctrine/doctrine-module ~1.0 -> found doctrine/doctrine-module[1.0.0, 1.0.1, 1.1.0, 1.2.0] but it conflicts with your root composer.json require (^4.1.0).
    - phpro/zf-doctrine-hydration-module v3.0.0 requires doctrine/doctrine-module ^1.2 -> found doctrine/doctrine-module[1.2.0] but it conflicts with your root composer.json require (^4.1.0).
    - phpro/zf-doctrine-hydration-module v4.1.0 requires doctrine/doctrine-module ^1.2 || ^2.1.7 -> found doctrine/doctrine-module[1.2.0, 2.1.7, 2.1.8, 2.1.9, 2.1.10] but it conflicts with your root composer.json require (^4.1.0).
    - Root composer.json requires laminas-api-tools/api-tools-doctrine ^2.1 -> satisfiable by laminas-api-tools/api-tools-doctrine[2.1.0, ..., 2.4.0].

This module requires "doctrine/doctrine-module": "^1.2 || ^2.1.7", so we can't update it unless we fix it there.

@tasselchof tasselchof changed the title Fix Added 4.0 version of laminas-hydrator, dropped old dependency Jan 29, 2022
@tasselchof tasselchof changed the title Added 4.0 version of laminas-hydrator, dropped old dependency Added ^4.0 version of laminas-hydrator, dropped old dependency Jan 29, 2022
@tasselchof
Copy link
Author

Hey, @Ocramius how to run those CI tests to get it done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants