ArrayUtils::iteratorToArray() different behaviour when recursive is false

[thomasvargiu]

ArrayUtils::iteratorToArray() has a different behaviour when $iterator is a Traversable object with a toArray() method.

When $recursive === false the method returns the result of its iterator, but when $recursive === true it returns the result of its toArray() method.

For a next major release I would suggest to make the method simplier without to handle objects with toArray() methods.
Another solution could be to return the toArray() even when $recursive === false.

laminas-stdlib/src/ArrayUtils.php

Lines 233 to 247 in f0b299d

	if (! is_array($iterator) && ! $iterator instanceof Traversable) {
	throw new Exception\InvalidArgumentException(__METHOD__ . ' expects an array or Traversable object');
	}
	if (! $recursive) {
	if (is_array($iterator)) {
	return $iterator;
	}
	return iterator_to_array($iterator);
	}
	if (is_object($iterator) && method_exists($iterator, 'toArray')) {
	return $iterator->toArray();
	}

[Ocramius]

Looks like a clear bug to me 👍

For a next major release I would suggest to make the method simplier without to handle objects with toArray() methods.

Totally agree: restricting inputs will help a lot here. We can most certainly design a separate utility that works with iterators, if needed.

[garygitton]

@thomasvargiu Do you have an example of an object that I could try ?

[Ocramius]

Handled in #42