Fix #18 call ->toArray() on Traversable instances given to ArrayUtils::iteratorToArray() only for instances which are **not** Iterator implementations
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Gitton <[email protected]>
Ocramius
force-pushed
the
fix/arrayutils-iterator-to-array-different-behaviour-when-recursive-is-false
branch
from
3026694 to
2d3358f
Compare
…h PHP 7.3+ This effectively removes a property type definition (only for PHP 7.4+)
Ocramius
approved these changes
Dec 24, 2021
There was a problem hiding this comment.
Moved to 3.6.x as target and rebased: overall excellent work, thanks @garygitton!
Ocramius
changed the title
ArrayUtils::toArray() value only for Traversable instances which are **not** Iterator implementations
Ocramius
changed the title
ArrayUtils::toArray() value only for Traversable instances which are **not** Iterator implementations->toArray() on Traversable instances given to ArrayUtils::iteratorToArray() only for instances which are **not** Iterator implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix of the issue #18 (ArrayUtils::iteratorToArray() different behaviour when recursive is false)
No when we use
ArrayUtils::iteratorToArraywith recursive = trueA new test is added in the class
ArrayUtilsTestunder the methodtestIteratorToArrayWithIteratorHavingMethodToArrayAndRecursiveIsFalseFixes #18