[13.x] Implement new calculateTaxes call #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
driesvints
commented
Jun 17, 2021
| @@ -23,7 +24,6 @@ trait PerformsCharges | |||
| public function charge($amount, $paymentMethod, array $options = []) | |||
| { | |||
| $options = array_merge([ | |||
| 'automatic_tax' => $this->automaticTaxPayload(), | |||
There was a problem hiding this comment.
I removed this because it's not possible to use automatic tax with payment intents atm it seems.
driesvints
commented
Jun 17, 2021
| @@ -791,7 +789,6 @@ protected function mergeItemsThatShouldBeDeletedDuringSwap(Collection $items) | |||
| protected function getSwapOptions(Collection $items, array $options = []) | |||
| { | |||
| $payload = [ | |||
| 'automatic_tax' => $this->automaticTaxPayload(), | |||
There was a problem hiding this comment.
I removed this because disabling automatic taxes during a swap is unlikely to happen. People can still do this by passing options explicitly if they want.
driesvints
commented
Jun 17, 2021
| @@ -1132,7 +1129,6 @@ public function latestInvoice() | |||
| public function upcomingInvoice(array $options = []) | |||
| { | |||
| return $this->owner->upcomingInvoice(array_merge([ | |||
| 'automatic_tax' => $this->automaticTaxPayload(), | |||
There was a problem hiding this comment.
I removed this because the underlying upcomingInvoice already adds this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new
Cashier::calculateTaxes()static method that'll allow you enable automatic tax calculation on all relevant Stripe calls. By default it follows Stripe's behavior and is set tofalse. Additionally, the previouswithTaxmethod is now deprecated as it is not needed anymore. You can now use your code as regularly without the need of using extra methods. This method call goes into the boot method of yourApServiceProvider.Also, the
tax_id_collectionis now enabled by default when the calculation of taxes is enabled. This PR also fixes a typo for an forgotten rename ofcollectsTaxIds.I'll send in a PR to the docs when this one is accepted.