-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.x] Implement new calculateTaxes call #1198
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,6 @@ | |
use Illuminate\Database\Eloquent\Model; | ||
use Illuminate\Support\Collection; | ||
use InvalidArgumentException; | ||
use Laravel\Cashier\Concerns\HandlesTaxes; | ||
use Laravel\Cashier\Concerns\InteractsWithPaymentBehavior; | ||
use Laravel\Cashier\Concerns\Prorates; | ||
use Laravel\Cashier\Database\Factories\SubscriptionFactory; | ||
|
@@ -23,7 +22,6 @@ | |
*/ | ||
class Subscription extends Model | ||
{ | ||
use HandlesTaxes; | ||
use HasFactory; | ||
use InteractsWithPaymentBehavior; | ||
use Prorates; | ||
|
@@ -791,7 +789,6 @@ protected function mergeItemsThatShouldBeDeletedDuringSwap(Collection $items) | |
protected function getSwapOptions(Collection $items, array $options = []) | ||
{ | ||
$payload = [ | ||
'automatic_tax' => $this->automaticTaxPayload(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I removed this because disabling automatic taxes during a swap is unlikely to happen. People can still do this by passing options explicitly if they want. |
||
'items' => $items->values()->all(), | ||
'payment_behavior' => $this->paymentBehavior(), | ||
'proration_behavior' => $this->prorateBehavior(), | ||
|
@@ -1132,7 +1129,6 @@ public function latestInvoice() | |
public function upcomingInvoice(array $options = []) | ||
{ | ||
return $this->owner->upcomingInvoice(array_merge([ | ||
'automatic_tax' => $this->automaticTaxPayload(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I removed this because the underlying |
||
'subscription' => $this->stripe_id, | ||
], $options)); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this because it's not possible to use automatic tax with payment intents atm it seems.