Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fix error event listener in Vite prefetching #53439

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented Nov 7, 2024

Currently assigned as link.error, this handler is effectively doing nothing. This ensures the handler is actually registering the event listener.

Edit: for reference I discovered this on debugging with Firefox, which erred on loading the assets due to being returned with a no-cache header in my local setup, thus causing the first batch of asset loads to fail and no new batch to be scheduled. After this adjustment all of them were added.

@taylorotwell taylorotwell merged commit 47a6953 into laravel:11.x Nov 7, 2024
31 checks passed
@timacdonald
Copy link
Member

My bad. Thanks, @jnoordsij.

@jnoordsij jnoordsij deleted the patch-1 branch November 8, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants