Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fix error event listener in Vite prefetching #53439

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[11.x] Fix error event listener in Vite prefetching #53439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e84aa70
Fix error event listener in Vite prefetching
jnoordsij Nov 7, 2024
60e975b
Fix FoundationViteTest to use onerror
jnoordsij Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Foundation/Vite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ public function __invoke($entrypoints, $buildDirectory = null)

if (assets.length) {
link.onload = () => loadNext(assets, 1)
link.error = () => loadNext(assets, 1)
link.onerror = () => loadNext(assets, 1)
}
}

Expand Down
4 changes: 2 additions & 2 deletions tests/Foundation/FoundationViteTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,7 +1359,7 @@ public function testItCanPrefetchEntrypoint()

if (assets.length) {
link.onload = () => loadNext(assets, 1)
link.error = () => loadNext(assets, 1)
link.onerror = () => loadNext(assets, 1)
}
}

Expand Down Expand Up @@ -1637,7 +1637,7 @@ public function testItPrefetchesCss()

if (assets.length) {
link.onload = () => loadNext(assets, 1)
link.error = () => loadNext(assets, 1)
link.onerror = () => loadNext(assets, 1)
}
}

Expand Down