update to latest AWS SDK release #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS SDK version we were on, 1.15.69, is pretty old and a customer pointed out in launchdarkly/ld-relay#127 that it's missing support for newer AWS authentication schemes. The customer proposed updating to 1.23.22, which is the latest patch version of the minor version that added support for that feature, but that version is pretty old too by this point, so I propose that we bump it all the way up to the latest release. Anyone who's using
go-server-sdk-dynamodband does not want to use such a recent AWS version can simply pin to our previous release.I don't see anything in the Go AWS SDK changelog to suggest that there's anything backward-incompatible about doing this, and our tests do pass with it.