Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades the Go AWS SDK to v1.23.22 for AWS IRSA support #128

Closed
wants to merge 1 commit into from
Closed

upgrades the Go AWS SDK to v1.23.22 for AWS IRSA support #128

wants to merge 1 commit into from

Conversation

juanjbrown
Copy link

@juanjbrown juanjbrown commented Feb 3, 2021

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

#127

Describe the solution you've provided

Upgrades AWS SDK version to the latest bug fix version of v1.23 for AWS IRSA support.

@eli-darkly
Copy link
Contributor

Thanks for the PR. I think we may go a slightly different route by updating the AWS SDK version in the underlying integration library, https://github.com/launchdarkly/go-server-sdk-dynamodb, and then updating the version of that library in ld-relay - same result, except it will also benefit anyone who's using our Go SDK.

I'm inclined to update it to the latest AWS SDK release, 1.37.2, rather than 1.23.22, as it seems that they are following semantic versioning and not making breaking changes across minor versions. Are you aware of any reason not to do that? The code seems to work fine with 1.37.2 in our integration tests, and there are other bugfixes they've made along the way that might benefit Relay Proxy users.

@juanjbrown
Copy link
Author

@eli-darkly Thanks for the quick reply.

Yeah, AWS seems to be good at following semver. I was trying to make the minimum changes needed just in case 😅, but I can upgrade the SDK in the go-server-sdk-dynamodb project to 1.37.2 and then update its version and the AWS SDK here

@eli-darkly
Copy link
Contributor

@juanjbrown

but I can upgrade the SDK in the go-server-sdk-dynamodb project to 1.37.2 and then update its version and the AWS SDK here

You don't need to do anything, we're already on it - launchdarkly/go-server-sdk-dynamodb#3

@eli-darkly eli-darkly closed this Feb 4, 2021
LaunchDarklyCI pushed a commit that referenced this pull request Feb 4, 2021
don't attach Prometheus endpoint to the global ServeMux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants