GN-4693: Insert LPDC #429
Merged
GN-4693: Insert LPDC #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dkozickis
force-pushed
the
GN-4693
branch
2 times, most recently
from
8965cea to
5e007a0
Compare
dkozickis
requested review from
abeforgit,
piemonkey and
lagartoverde
and removed request for
abeforgit
piemonkey
reviewed
May 21, 2024
piemonkey
reviewed
May 23, 2024
| resource, | ||
| property: { | ||
| predicate: SRO('bekrachtigt').full, | ||
| object: sayDataFactory.literalNode(rdfaId), |
There was a problem hiding this comment.
Should this be .resourceNode(uri)?
There was a problem hiding this comment.
Thank you, yes. Changed
piemonkey
approved these changes
May 23, 2024
PR comment fixes
PR comment fixes
PR comment fixes
PR comment fixes
PR comment fixes
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Insert LPDC reference for besluit (decision)
connected issues and PRs:
Setup
app-gelinkt-notulerenPR - GN-4693: Proxy to LPDC service app-gelinkt-notuleren#183app-gnwith something likedocker compose -f docker-compose.yml -f docker-compose.dev.yml -f docker-compose.override.yml up,API_KEYforlpdc-serviceshould go intodocker-compose.override.ymlHow to test/reproduce
Repeat after me
CleanShot.2024-05-21.at.13.48.33.mp4
Challenges/uncertainties
Checks PR readiness