Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4693: Enable LPDC plugin #667

Merged
merged 4 commits into from
Aug 6, 2024
Merged

GN-4693: Enable LPDC plugin #667

merged 4 commits into from
Aug 6, 2024

Conversation

dkozickis
Copy link
Contributor

@dkozickis dkozickis commented May 27, 2024

Draft until RDFA editing available in Agendapoint editor

Overview

Insert LPDC reference for besluit (decision)

connected issues and PRs:

Setup

  1. Checkout frontend PR - GN-4693: Enable LPDC plugin #667
  2. Checkout master of app-gelinkt-notuleren - https://github.com/lblod/app-gelinkt-notuleren
  3. Start app-gn with something like docker compose -f docker-compose.yml -f docker-compose.dev.yml -f docker-compose.override.yml up, API_KEY for lpdc-service should go into docker-compose.override.yml. Ask me for the key if needed.
  4. Change config/environment.js:102 to http://localhost:4200/lpdc-service
  5. Start frontend locally with ember s --proxy http://localhost

How to test/reproduce

Repeat after me. Video is from plugins repo, but the idea is roughly the same, you should have decision/besluit in Agendapoint editor.

CleanShot.2024-05-21.at.13.48.33.mp4

Challenges/uncertainties

  • What needs to be shown in the search modal?
  • How should the node look in the UI really?

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

@dkozickis dkozickis changed the title Gn 4693 GN-4693: Enable LPDC plugin May 27, 2024
@dkozickis dkozickis requested review from abeforgit and piemonkey and removed request for abeforgit May 27, 2024 08:46
Copy link
Contributor

@piemonkey piemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inserting doesn't work as it can't find the inline_rdfa nodespec. I guess we should have switched over to this in place of the inline_rdfa mark when moving to rfdaAware: true, but it's possible that there are side-effects...

@dkozickis
Copy link
Contributor Author

@abeforgit is working on converting Agendapoints to RDFA Aware, leaving only Regulatory Statement for now 🙏🏻

@piemonkey
Copy link
Contributor

@abeforgit is working on converting Agendapoints to RDFA Aware, leaving only Regulatory Statement for now 🙏🏻

I feel like I'm missing something. Regulatory Statements aren't linked to a decision, so the 'insert LPDC' control is always disabled.

@dkozickis dkozickis marked this pull request as draft May 28, 2024 14:21
@abeforgit abeforgit marked this pull request as ready for review August 6, 2024 15:52
@abeforgit abeforgit enabled auto-merge August 6, 2024 15:53
@abeforgit abeforgit merged commit 8d4da60 into master Aug 6, 2024
3 checks passed
@abeforgit abeforgit deleted the GN-4693 branch August 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants