Add ability to link locations with the wider document automatically #517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Also move from dct:spatial to prov:atLocation.
I spent some time refactoring the address variable to re-use a load of the code from the oslo location node and so to benefit from these changes, but I realised that substantially increases the scope of the changes. Instead of finishing those changes, I've not committed them. If we think we should include them, I'll add them, otherwise I'll hold on to them for now.
The links are made in RDFa but only the backlink works in the RDFa tools. This is unfixed as we need to refactor how these nodes work anyway, so should do this then.
Edit: In order to avoid a weird situation of having 2
prov:atLocation
triples with different objects for each location, I included a more substantial refactor which 'de-variable-ifies' the location code. So, now:Things this does not include:
connected issues and PRs:
Jira ticket: https://binnenland.atlassian.net/browse/GN-5022
GN PR: lblod/frontend-gelinkt-notuleren#794
RB PR: lblod/frontend-reglementaire-bijlage#306
Setup
N/A
How to test/reproduce
In the besluit or snippet sample pages, insert locations into arbitrary documents, inside Besluits and inside Articles. The expectation (see jira) is that it will link the location to an article if it can find one or a besluit if it cannot. If it can't find either, it will be unlinked.
Challenges/uncertainties
N/A
Checks PR readiness