Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link locations to the surrounding document on insertion #794

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

piemonkey
Copy link
Contributor

@piemonkey piemonkey commented Dec 9, 2024

Overview

Just a matter of adding the new configuration.

Edit: now also includes location RDFa fix

A draft until the Plugins PR is in a release.

connected issues and PRs:

Plugins PR: lblod/ember-rdfa-editor-lblod-plugins#517
RB PR: lblod/frontend-reglementaire-bijlage#306
Jira ticket: https://binnenland.atlassian.net/browse/GN-5022

Setup

N/A

How to test/reproduce

Same as plugins PR, for agendapoints or RSs.

Challenges/uncertainties

I wasn't sure if we should do this on RSs, but I made a guess.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@piemonkey piemonkey marked this pull request as ready for review December 16, 2024 11:18
@abeforgit abeforgit merged commit e58511c into master Dec 18, 2024
3 checks passed
@abeforgit abeforgit deleted the feat/location-linking branch December 18, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants