Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concept of imported resources to editor #1212

Merged
merged 13 commits into from
Sep 10, 2024

Conversation

piemonkey
Copy link
Contributor

@piemonkey piemonkey commented Aug 9, 2024

Overview

This is covers 2 parts of the 3-part story of snippet rdfa linking:

  1. Snippet creation: Defining 'placeholder' resource URIs that will exist in the final document, making them accessible to the RDFa tools when creating a snippet and allowing us to create links from those resources to nodes in the snippet. Links to those resources is more troublesome and will come in a later PR.
  2. Template creation: Mapping placeholder resource URIs to real resource URIs that exist in the document.

The UI for linking placeholder resources to real ones is very rough, but should work for now.

connected issues and PRs:

Plugins PR: lblod/ember-rdfa-editor-lblod-plugins#462
and RB PR: lblod/frontend-reglementaire-bijlage#263.

Setup

Needs to be tested by being used in the plugins repo.

How to test/reproduce

See plugins PR for test steps.

Challenges/uncertainties

There were some problems with types after converting a component to gts and adding the necessary types packages. I think these were just being hidden by being assigned to any, so I had to convert some template only components to use gts to correct these.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@piemonkey piemonkey force-pushed the feat/snippet-resource-imports branch from 44ee369 to 5aeaf83 Compare August 19, 2024 08:32
@piemonkey piemonkey force-pushed the feat/snippet-resource-imports branch from 231bcb2 to 50fdd2f Compare August 29, 2024 13:37
Allows passing in of resources defined in other snippets in the snippet
list.
@piemonkey piemonkey force-pushed the feat/snippet-resource-imports branch from 50fdd2f to 513bc0c Compare August 29, 2024 13:59
@piemonkey
Copy link
Contributor Author

Reviewed as part of lblod/frontend-reglementaire-bijlage#263 so merging this.

@piemonkey piemonkey merged commit 3254b23 into master Sep 10, 2024
5 checks passed
@piemonkey piemonkey deleted the feat/snippet-resource-imports branch September 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant