-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add concept of imported resources to editor #1212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
3962b07
to
cf21e31
Compare
7 tasks
Filter from 'resourceNode' relationship editor lookup as linking to these resources is not supported
44ee369
to
5aeaf83
Compare
This was referenced Aug 20, 2024
Merged
231bcb2
to
50fdd2f
Compare
Allows passing in of resources defined in other snippets in the snippet list.
50fdd2f
to
513bc0c
Compare
Reviewed as part of lblod/frontend-reglementaire-bijlage#263 so merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is covers 2 parts of the 3-part story of snippet rdfa linking:
The UI for linking placeholder resources to real ones is very rough, but should work for now.
connected issues and PRs:
Plugins PR: lblod/ember-rdfa-editor-lblod-plugins#462
and RB PR: lblod/frontend-reglementaire-bijlage#263.
Setup
Needs to be tested by being used in the plugins repo.
How to test/reproduce
See plugins PR for test steps.
Challenges/uncertainties
There were some problems with types after converting a component to gts and adding the necessary types packages. I think these were just being hidden by being assigned to
any
, so I had to convert some template only components to use gts to correct these.Checks PR readiness