Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messy version of allowing resources to link to imported resources #1213

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piemonkey
Copy link
Contributor

Overview

To allow for linking from resources in a snippet to those imported, adds imported resources to those listed for creating relationships, but actually the linking only works if we create a NamedNode relationship instead of a ResourceNode. This is just a draft as we need to figure out a better way to do this.

connected issues and PRs:

Made to #1212 as that is the more finalised part of the design.

Setup

Link to plugins PR.

How to test/reproduce

See plugins PR for most details. When creating a link to an imported resource from a resource in the snippet, click 'add relationship' as normal, but create a NamedNode link with a manually entered URI.

Challenges/uncertainties

Need to figure out the right way to do this.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@piemonkey piemonkey force-pushed the feat/snippet-resource-imports branch from 3962b07 to cf21e31 Compare August 9, 2024 11:33
@piemonkey piemonkey force-pushed the feat/snippet-rdfa-linking branch from 57973ea to b7b9a77 Compare August 9, 2024 11:33
@piemonkey piemonkey force-pushed the feat/snippet-rdfa-linking branch from b7b9a77 to 0952376 Compare August 13, 2024 13:46
@piemonkey piemonkey force-pushed the feat/snippet-resource-imports branch from 50fdd2f to 513bc0c Compare August 29, 2024 13:59
Base automatically changed from feat/snippet-resource-imports to master September 10, 2024 08:53
@elpoelma
Copy link
Contributor

@piemonkey do you think this PR is still necessary? I don't think this is really a usecase right?

@piemonkey
Copy link
Contributor Author

This definitely isn't something we need right now, but I think it's something that makes sense as there's no reason why relationships should need to have the subject in the outer document rather than the subject being inside the snippet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants