Introducing ember-plausible #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 9, 2022 22:17
This uses the global configuration without any enabling or custom goals in the application. This might change in the future when automatic enabling is removed.
Using this hook, we can make sure the promise for enabling the analytics is finished, before continuing with the rest of the route. Something we cannot control in an initializer. The automatic enabling might be removed in the future, so we moved the code.
nvdk
reviewed
Jun 10, 2022
There was a problem hiding this comment.
in the interest of backwards compatibility (and not having to change the env vars on all servers) I would keep using EMBER_ANALYTICS_APP_DOMAIN. If we then also provide a default for conf.apiHost in the application route no config changes need to happen on the server.
nvdk
approved these changes
Jun 10, 2022
|
@nvdk Do you want to include some default URL for the analytics endpoint in the code/config? |
|
@benjay10 sorry wasn't very clear on this, as I was unsure myself. I think given that's it's only on two instances it's ok. I'll just adjust the env vars accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes old analytics set-up based on Plausible directly and introduced the ember-plausible addon. Analytics are enabled on all routes by default.