Plausible custom event 'Create agendapoint' #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 9, 2022 22:17
This uses the global configuration without any enabling or custom goals in the application. This might change in the future when automatic enabling is removed.
Using this hook, we can make sure the promise for enabling the analytics is finished, before continuing with the rest of the route. Something we cannot control in an initializer. The automatic enabling might be removed in the future, so we moved the code.
This custom event logs the event 'Create agendapoint' and it's template id and title. For this I added the used template as an argument to the onCreate action such that we can keep the Plausible code limited to controllers, routes and not burry that deep inside components.
|
Also, this PR is based on another PR where ember-plausible is introduced. See: #285 |
|
|
nvdk
approved these changes
Jun 10, 2022
|
I get the reflex to include the id, but I don't think it has much value in the analytics tools to be honest |
|
@nvdk I thought I tried clicking on the Goal, but no 🤦 It indeed shows the properties. Including the id is for easier data processing later, but it shoud be one or the other, not both. I'll go ahead and remove the ID then. |
The template ID is rudimentary information if you also have the title. The title should be pretty much as unique of an identifier as the ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes to post analytics about a custom event for creating an agendapoint and includes the template id and the title. I added the selected template as an argument to the onCreate action so that I could write the analytics code in the controller instead of the component.
The custom events could not be checked on the dashboard yet. I did not have access to the dashboard's configuration to inspect if the custom event's properties have correctly been logged. The public dashboard only shows the goal, so I know it works at least.