Support for editor with reworked RDFa handling #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ran prettier on the file, couldn't separate the changes
The problem wasn't the import, the file was simply renamed in the source
abeforgit
force-pushed
the
feat/rdfa-editing-ui
branch
from
a597fd5 to
05b12b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See editor and plugin PRs for details. This uses these versions but has the UI for them turned off. The aim is for identical functionality to before this update but using the new internals.
connected issues and PRs:
lblod/ember-rdfa-editor#1021
lblod/ember-rdfa-editor-lblod-plugins#357
Setup
Should need linking to the latest of the plugins and editor branches
How to test/reproduce
By default everything should behave as before. New functionality can be tested by changing
@shouldEditRdfato true on either regulatory statement or besluit edit templates.Challenges/uncertainties
See other PRs.
Checks PR readiness