Plugin support for reworked RDFa parsing/serializing and UI/UX #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piemonkey
changed the title
7 tasks
* Set up dummy app to use article-structure-plugin * Convert chapter article structures to be rdfa aware * Modify article structure commands to insert rdfa aware structures * Convert section and title article structures to be rdfa aware * Convert remaining article structures to be rdfa aware * Correctly set up backlinks when wrapping article structures * Clean up some article-structure rdfa handling * Handle article structure headers and titles as literals * Correctly encode article structure numbers as external properties * Correctly recreate article structure body backlinks on reload * Set selection correctly after inserting article structures * Fix RDFa aware version of article paragraph structure * Fix standard-template-plugin's use of StructureSpec after RDFa changes * Fix updating of section numbers in article structure plugin * Fix resource structures when wrapping article structures * Correct article structure wrapping command to change the number content
Backwards compatability of article structure nodes
Rdfa/actual structure compat
* fix: make editable node plugin work * fix: use subject in structure specs and add some utils * feat: make text variable work * feat: make number variable work * feat: make date variable work * feat: make codelists work * fix: dates not inserting correctly * feat: make location var work * make text-variable completely backwards compatible * remove custom attributes from text-variable * make number-variable backwards compatible * drop obsolete content-selector for number node * fix(number-variables): remove content rdfa-attribute if it is empty * make date-variable backwards compatible * drop obsolete content-selector for date node * make location variable work in backwards-compatible way * make codelists work in backwards-compatible way * make getParsedRdfaAttribute only return attribute-properties * convert address-variable to new system * fix return type of number getter * revert changes to location variable --------- Co-authored-by: Elena Poelman <[email protected]>
GN-4650: Snippet selection placeholder in template
…rting-variables GN-4732: ensure variables are selected/focused after insertion
* wip: update editor * update editor to latest dev commit * update nodes to use rdfa-attr-spec function * update dummy pages to use rdfa-aware nodes * enable rdfa-awareness on regulatory statement doc node-spec * lint: remove unused imports * lint: prettier * make links in dummy pages rdfa-aware * feat(citation-plugin): update citation plugin to work with rdfa-aware link nodes * fix invisible_rdfa typo * enable rdfa-awareness on besluit-editable-nodes doc node-spec * use full uris when inserting/removing decision type properties * fix issue with toDOM of besluit_articel_structure node-spec * chore: bump editor to latest release * fix: revert dummy app route back to js --------- Co-authored-by: abeforgit <[email protected]>
Allow to insert structure even if insertion range does not have RDFA attributes.
piemonkey
force-pushed
the
feat/rdfa-editing-ui
branch
from
10a641c to
a2a8308
Compare
piemonkey
force-pushed
the
feat/rdfa-editing-ui
branch
from
a2a8308 to
f473cdf
Compare
…ecs (#410) * drop unnecessary backwards-compatible parse-rule for decision node * drop unnecessary backwards-compatible parse-rule for decision-title node * drop unnecessary backwards-compatible parse-rule for description node * drop unnecessary backwards-compatible parse-rule for motivering node * drop unnecessary backwards-compatible parse-rule for article-container node * drop unnecessary backwards-compatible parse-rule for decision-article node * drop unnecessary backwards-compatible parse-rule for decision-article-content node * linting --------- Co-authored-by: Arne Bertrand <[email protected]>
* drop unnecessary backwards-compatible parse-rule for decision node * drop unnecessary backwards-compatible parse-rule for decision-title node * drop unnecessary backwards-compatible parse-rule for description node * drop unnecessary backwards-compatible parse-rule for motivering node * drop unnecessary backwards-compatible parse-rule for article-container node * drop unnecessary backwards-compatible parse-rule for decision-article node * drop unnecessary backwards-compatible parse-rule for decision-article-content node * linting * fix(decision-article): ensure that article number is positioned inline * make setStartNumber and getStartNumber properties optional * make numberConfig.convertNumber optional * rework rdfa-aware besluit_article node * adapt insert-structure command to support decision articles * GN-4810: get the `roadsign-regulation` plugin working with the `rdfa-aware` decision nodes (#418) --------- Co-authored-by: abeforgit <[email protected]>
* drop unnecessary backwards-compatible parse-rule for decision node * drop unnecessary backwards-compatible parse-rule for decision-title node * drop unnecessary backwards-compatible parse-rule for description node * drop unnecessary backwards-compatible parse-rule for motivering node * drop unnecessary backwards-compatible parse-rule for article-container node * drop unnecessary backwards-compatible parse-rule for decision-article node * drop unnecessary backwards-compatible parse-rule for decision-article-content node * linting * fix(decision-article): ensure that article number is positioned inline * make setStartNumber and getStartNumber properties optional * make numberConfig.convertNumber optional * rework rdfa-aware besluit_article node * ensure decision nodes behave the same as before in terms of UX (isolating/defining/selectable) * adapt insert-structure command to support decision articles --------- Co-authored-by: abeforgit <[email protected]>
Co-authored-by: Arne Bertrand <[email protected]>
dkozickis
force-pushed
the
feat/rdfa-editing-ui
branch
from
4dfeb71 to
8cfa3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A meta-PR to gather any work from the RDFa handling overhaul. So far only includes the change to copy the 'editable nodes' route from
ember-rdfa-editor, to allow for testing any changes to plugins.connected issues and PRs:
Setup
Adds a new route 'editable node sample', into the dummy app which should make RDFa visible and editable.
How to test/reproduce
Challenges/uncertainties
Checks PR readiness