Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add snippet placeholder nodespecs #661

Merged
merged 3 commits into from
May 17, 2024
Merged

Re-add snippet placeholder nodespecs #661

merged 3 commits into from
May 17, 2024

Conversation

piemonkey
Copy link
Contributor

Overview

These commits were in futurenow after #653 was merged, but are no longer there or in master.

As far as I can tell from examining the git history, these are the only commits that are missing.

connected issues and PRs:

#653

Setup

N/A

How to test/reproduce

Snippet placeholders work correctly in Regulatory statements.

Challenges/uncertainties

It wasn't clear what rebase erased these commits, so the analysis was manual. I suggest git push --force-with-lease for anyone push-forcing to avoid this in the future.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

Copy link
Contributor

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it's basically the same thing I did in my branch

@piemonkey piemonkey merged commit 7497607 into master May 17, 2024
3 checks passed
@piemonkey piemonkey deleted the fix/branch-repair branch May 17, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants