Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add snippet placeholder nodespec and view so they are rendered correctly in RS editor. Required to use rdfa aware snippet insert component.
connected issues and PRs:
binnenland.atlassian.net/browse/GN-4782
Uses: lblod/ember-rdfa-editor#1188
And: lblod/ember-rdfa-editor-lblod-plugins#419
RB part: lblod/frontend-reglementaire-bijlage#241
Setup
You'll need to get templates from the latest RB in order to have snippet placeholders, so need to change
regulatoryStatementEndpoint
andregulatoryStatementFileEndpoint
to point to local and run the RB stack.How to test/reproduce
In RB, publish a template with a snippet placeholder, and verify that in GN you can select it and insert a relevant snippet.
Challenges/uncertainties
I don't know if it was a conscious choice not to use the rdfa aware version of the snippet insert component, but I assumed it was just an oversight.
Checks PR readiness