Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snippet placeholder #653

Merged
merged 2 commits into from
May 2, 2024
Merged

Add snippet placeholder #653

merged 2 commits into from
May 2, 2024

Conversation

piemonkey
Copy link
Contributor

@piemonkey piemonkey commented Apr 29, 2024

Overview

Add snippet placeholder nodespec and view so they are rendered correctly in RS editor. Required to use rdfa aware snippet insert component.

connected issues and PRs:

binnenland.atlassian.net/browse/GN-4782
Uses: lblod/ember-rdfa-editor#1188
And: lblod/ember-rdfa-editor-lblod-plugins#419
RB part: lblod/frontend-reglementaire-bijlage#241

Setup

You'll need to get templates from the latest RB in order to have snippet placeholders, so need to change regulatoryStatementEndpoint and regulatoryStatementFileEndpoint to point to local and run the RB stack.

How to test/reproduce

In RB, publish a template with a snippet placeholder, and verify that in GN you can select it and insert a relevant snippet.

Challenges/uncertainties

I don't know if it was a conscious choice not to use the rdfa aware version of the snippet insert component, but I assumed it was just an oversight.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@piemonkey piemonkey force-pushed the feat/snippet-placeholder branch from ecc9348 to 6cc44af Compare April 29, 2024 10:54
@piemonkey piemonkey force-pushed the feat/snippet-placeholder branch from 6cc44af to 06522b4 Compare April 29, 2024 13:34
@piemonkey piemonkey changed the title Use rdfa aware snippet insert component Add snippet placeholder Apr 30, 2024
@piemonkey piemonkey merged commit 75a1698 into futurenow May 2, 2024
3 checks passed
@piemonkey piemonkey deleted the feat/snippet-placeholder branch May 2, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants