Change Services() to return pointers

leanovate · Apr 3, 2019 · 503e07e · 503e07e
1 parent 1f35cad
commit 503e07e
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/mite/api.go b/mite/api.go
@@ -12,7 +12,7 @@ const layout = "2006-01-02"
 
 type MiteApi interface {
 	Projects() ([]*Project, error)
-	Services() ([]Service, error)
+	Services() ([]*Service, error)
 	TimeEntries(params *TimeEntryParameters) ([]TimeEntry, error)
 	TimeEntry(id string) (*TimeEntry, error)
 }

diff --git a/mite/service.go b/mite/service.go
@@ -10,33 +10,33 @@ type Service struct {
 	Note string
 }
 
-func (a *miteApi) Services() ([]Service, error) {
-	srs := []ServiceResponse{}
-	err := a.get("services.json", &srs)
-	if err != nil {
-		return nil, err
-	}
-
-	services := []Service{}
-	for _, sr := range srs {
-		services = append(services, sr.ToService())
-	}
-
-	return services, nil
-}
-
-type ServiceResponse struct {
+type serviceResponse struct {
 	Service struct {
 		Id   int    `json:"id"`
 		Name string `json:"name"`
 		Note string `json:"note"`
 	} `json:"service"`
 }
 
-func (r ServiceResponse) ToService() Service {
-	return Service{
+func (r *serviceResponse) ToService() *Service {
+	return &Service{
 		Id:   fmt.Sprintf("%d", r.Service.Id),
 		Name: r.Service.Name,
 		Note: r.Service.Note,
 	}
 }
+
+func (a *miteApi) Services() ([]*Service, error) {
+	srs := []serviceResponse{}
+	err := a.get("services.json", &srs)
+	if err != nil {
+		return nil, err
+	}
+
+	services := []*Service{}
+	for _, sr := range srs {
+		services = append(services, sr.ToService())
+	}
+
+	return services, nil
+}