-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update simplecov dependency to 0.14.1 #117
Update simplecov dependency to 0.14.1 #117
Conversation
f085a90
to
b936364
Compare
I also want to use |
Hi, I don't understand if this PR is ok and my branch fixes your issue or if this doesn't work and I should do something else |
@tagliala thanks for your quick replying. |
This change introduces an RSpec plugin for RuboCop. It addresses a few of the worst offenses, mostly by deleting tests that weren't really doing anything useful in the first place. Additionally, until Coveralls gets non-naggy Ruby 2.4 support, I'm pulling it: lemurheavy/coveralls-ruby#117
@tagliala the PR looks good to me. Can we get this merged? Right now we're allowing build-failures on travis for 2.4.0 because of this |
Hi, I'm not going to use Ruby 2.4.0 at all, but it would be nice to switch my applications to 2.4.1 asap. Is there something I can do to speed up things? |
@tagliala what's the ETA on merging this? Not sure what's blocking... |
b936364
to
bc984f7
Compare
There is a failing spec with the just released simplecov 0.14.0
I'm trying to take a look |
Offending commit: simplecov-ruby/simplecov@d4756e4 Please let me know what is the expected behavior which we would expect from this change |
Done. Looks good to me 👍 |
582e172
to
e908a38
Compare
e908a38
to
1ab5eae
Compare
Updated to 0.14.1 |
Hi @tagliala
Ruby 2.4.1 was released as a information. |
@junaruga thanks! I was checking Ruby's website every day. I will try this release and I hope I will not face that issue again |
ba0bc03
to
6b4c1a1
Compare
Tested against 2.4.1 All green on travis: https://travis-ci.org/lemurheavy/coveralls-ruby/builds/214231009, I hope this could be merged |
6b4c1a1
to
e652e81
Compare
Update: Test against Ruby 2.2.7 |
Good day, @nickmerwin or other maintainers. |
This is blocking my project, too :( |
Regarding @junaruga 's comment, I'm happy to come on as a co-maintainer to help out, if you're interested, @nickmerwin |
Adds Ruby 2.4.1 Updates 2.2.5 to 2.2.7 and 2.3.1 to 2.3.4
SimpleCov 0.14.0 skip the :nocov: comments along with the code that they skip. This commit updates a failing spec to reflect that change. Ref: simplecov-ruby/simplecov@d4756e4
e652e81
to
a3c262f
Compare
Update: Test against Ruby 2.3.4 Fails because of Travis CI: travis-ci/travis-ci#7535 |
@tagliala looks like we're good to merge? |
@ajm188 Travis is still not able to test against Ruby 2.3.4, but I'm pretty confident that everything would be fine. PS: I cannot merge, I'm a contributor because I did a couple of PR in the past, but I'm not a member of this repo. |
Because coveralls 0.8.20 for Ruby 2.4 compatibility was released. See also lemurheavy/coveralls-ruby#117
@nickmerwin could you please restart the build at https://travis-ci.org/lemurheavy/coveralls-ruby ? 2.3.4 is now available on Travis |
@tagliala done -- we're green! |
Because coveralls 0.8.20 for Ruby 2.4 compatibility was released. See also lemurheavy/coveralls-ruby#117
Fix #116