-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test(errdefs): use more helpers, increase test coverage (#358)
Signed-off-by: Gyuho Lee <[email protected]> --------- Signed-off-by: Gyuho Lee <[email protected]>
- Loading branch information
Showing
8 changed files
with
398 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| package v1 | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "io" | ||
| "net/http" | ||
|
|
||
| "github.com/leptonai/gpud/manager/packages" | ||
| ) | ||
|
|
||
| // GetPackageStatus fetches the GPUd package status from the GPUd admin API. | ||
| func GetPackageStatus(ctx context.Context, url string, opts ...OpOption) ([]packages.PackageStatus, error) { | ||
| op := &Op{} | ||
| if err := op.applyOpts(opts); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| httpClient := op.httpClient | ||
| req, err := http.NewRequestWithContext(ctx, "GET", url, nil) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| resp, err := httpClient.Do(req) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer resp.Body.Close() | ||
|
|
||
| if resp.StatusCode != http.StatusOK { | ||
| return nil, fmt.Errorf("unexpected status code %v received", resp.StatusCode) | ||
| } | ||
|
|
||
| rawBody, err := io.ReadAll(resp.Body) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| var ret []packages.PackageStatus | ||
| if err := json.Unmarshal(rawBody, &ret); err != nil { | ||
| return nil, err | ||
| } | ||
| return ret, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| package v1 | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
|
|
||
| "github.com/leptonai/gpud/manager/packages" | ||
| ) | ||
|
|
||
| func TestGetStatus(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| serverResponse func(w http.ResponseWriter, r *http.Request) | ||
| wantErr bool | ||
| expectedData []packages.PackageStatus | ||
| }{ | ||
| { | ||
| name: "successful response", | ||
| serverResponse: func(w http.ResponseWriter, r *http.Request) { | ||
| assert.Equal(t, http.MethodGet, r.Method) | ||
|
|
||
| response := []packages.PackageStatus{ | ||
| { | ||
| Name: "test-package", | ||
| IsInstalled: true, | ||
| Installing: false, | ||
| Progress: 100, | ||
| TotalTime: 1 * time.Hour, | ||
| Status: true, | ||
| TargetVersion: "1.0.0", | ||
| CurrentVersion: "1.0.0", | ||
| ScriptPath: "/path/to/script", | ||
| Dependency: [][]string{{"dep1", "1.0.0"}}, | ||
| }, | ||
| } | ||
| assert.NoError(t, json.NewEncoder(w).Encode(response)) | ||
| }, | ||
| wantErr: false, | ||
| expectedData: []packages.PackageStatus{ | ||
| { | ||
| Name: "test-package", | ||
| IsInstalled: true, | ||
| Installing: false, | ||
| Progress: 100, | ||
| TotalTime: 1 * time.Hour, | ||
| Status: true, | ||
| TargetVersion: "1.0.0", | ||
| CurrentVersion: "1.0.0", | ||
| ScriptPath: "/path/to/script", | ||
| Dependency: [][]string{{"dep1", "1.0.0"}}, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| name: "server returns error status", | ||
| serverResponse: func(w http.ResponseWriter, r *http.Request) { | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| }, | ||
| wantErr: true, | ||
| expectedData: nil, | ||
| }, | ||
| { | ||
| name: "invalid JSON response", | ||
| serverResponse: func(w http.ResponseWriter, r *http.Request) { | ||
| _, err := w.Write([]byte("invalid json")) | ||
| assert.NoError(t, err) | ||
| }, | ||
| wantErr: true, | ||
| expectedData: nil, | ||
| }, | ||
| { | ||
| name: "context canceled", | ||
| serverResponse: func(w http.ResponseWriter, r *http.Request) { | ||
| // Simulate a slow response that will be canceled | ||
| time.Sleep(100 * time.Millisecond) | ||
| assert.NoError(t, json.NewEncoder(w).Encode([]packages.PackageStatus{})) | ||
| }, | ||
| wantErr: true, | ||
| expectedData: nil, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| // Create test server | ||
| server := httptest.NewTLSServer(http.HandlerFunc(tt.serverResponse)) | ||
| defer server.Close() | ||
|
|
||
| var ctx context.Context | ||
| var cancel context.CancelFunc | ||
| if tt.name == "context canceled" { | ||
| ctx, cancel = context.WithTimeout(context.Background(), 50*time.Millisecond) | ||
| } else { | ||
| ctx, cancel = context.WithTimeout(context.Background(), time.Second) | ||
| } | ||
| defer cancel() | ||
|
|
||
| // Call GetStatus with the test server's URL | ||
| status, err := GetPackageStatus(ctx, server.URL) | ||
|
|
||
| if tt.wantErr { | ||
| assert.Error(t, err) | ||
| assert.Nil(t, status) | ||
| } else { | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, tt.expectedData, status) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.