test(errdefs): use more helpers, increase test coverage #358
+398
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
==========================================
+ Coverage 23.41% 23.53% +0.12%
==========================================
Files 287 288 +1
Lines 25695 25698 +3
==========================================
+ Hits 6016 6048 +32
+ Misses 19074 19042 -32
- Partials 605 608 +3 ☔ View full report in Codecov by Sentry. |
gyuho
force-pushed
the
errdefs
branch
2 times, most recently
from
e9fe4c0 to
473a38f
Compare
xiang90
reviewed
Feb 7, 2025
|
lgtm. defer to @cardyok |
gyuho
force-pushed
the
errdefs
branch
2 times, most recently
from
8d85583 to
3a7b7a9
Compare
eahydra
reviewed
Feb 8, 2025
client/v1/status.go
Outdated
| @@ -0,0 +1,46 @@ | |||
| package v1 | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
we should rename the file name, such as packages.go? or package_status.go? status.go is too general.
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
eahydra
reviewed
Feb 11, 2025
client/v1/status.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| httpClient := op.httpClient |
There was a problem hiding this comment.
should move it to line 25
Signed-off-by: Gyuho Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gyuho Lee [email protected]