Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapshotStore saves an entity's snapshot history #174

Closed
xirc opened this issue Oct 14, 2022 · 0 comments · Fixed by #184
Closed

SnapshotStore saves an entity's snapshot history #174

xirc opened this issue Oct 14, 2022 · 0 comments · Fixed by #184
Labels
enhancement New feature or request
Milestone

Comments

@xirc
Copy link
Contributor

xirc commented Oct 14, 2022

SnapshotStore ( ~ v2.1.0) saves an entity's snapshot as a snapshot, not an event. One of the reasons behind this is reducing storage space for saving entitys' snapshots.

As same as other persistent actors such as RaftActor, SnapshotStore is wanted to be rolled back to a certain point (timestamp or sequence number). To support this rollback, SnapshotStore should save an entity's snapshot as an event instead. Note that this change will increase required storage space to save snapshots.

Considerations:

  • SnapshotStore maintains data backward compatibility. The new SnapshotStore should read a snapshot that the old SnapshotStore saved.
  • The new SnapshotStore should not change message protocols as possible not to affect other actors such as RaftActor and SnapshotSyncManager.
@xirc xirc added the enhancement New feature or request label Oct 14, 2022
@xirc xirc added this to the v2.2.0 milestone Oct 14, 2022
@xirc xirc linked a pull request Dec 1, 2022 that will close this issue
@xirc xirc closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant