Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persit EntitySnapshot as an event #184

Merged
merged 17 commits into from
Nov 22, 2022
Merged

Persit EntitySnapshot as an event #184

merged 17 commits into from
Nov 22, 2022

Conversation

ydash
Copy link
Contributor

@ydash ydash commented Nov 1, 2022 •
edited
Loading

made following changes for implementing EntitySnapshot backup:

  • save EntitySnapshot as an Event
    • use persistAsync for avoiding performance degradation
    • if persistAsync failed, return SaveSnapshotFailure by onPersistFailure function
  • save EntitySnapshot as an Snapshot per configuration of lerna.akka.entityreplication.raft.snapshot-store.snapshot-every
    • if saveSnapshot return persistence.SaveSnapshotSuccess, output debug log.
    • if saveSnapshot return persistence.SaveSnapshotFailure output warn log.

@ydash ydash changed the title Persits EntitySnapshot as a event Persit EntitySnapshot as an event Nov 2, 2022
@ydash ydash marked this pull request as ready for review November 2, 2022 10:31
@ydash ydash force-pushed the impl-snapshot-generation-management branch from 1dc8d45 to d6f1758 Compare November 4, 2022 04:38
@nyamada-tis
refactor: rename lerna.akka.entityreplication.raft.snapshot-store to …
f09c690 
…lerna.akka.entityreplication.raft.entity-snapshot-store
negokaz
negokaz previously approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@negokaz negokaz enabled auto-merge November 17, 2022 09:20
@negokaz negokaz merged commit 1212e6b into master Nov 22, 2022
@negokaz negokaz deleted the impl-snapshot-generation-management branch November 22, 2022 06:49
@xirc xirc linked an issue Dec 1, 2022 that may be closed by this pull request
SnapshotStore saves an entity's snapshot history #174
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirc xirc xirc approved these changes

@negokaz negokaz negokaz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SnapshotStore saves an entity's snapshot history
4 participants
@ydash @negokaz @xirc @nyamada-tis