Add unit tests of SnapshotStore #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 25, 2022 10:17
xirc
commented
Oct 25, 2022
src/test/scala/lerna/akka/entityreplication/raft/snapshot/ShardSnapshotStoreFailureSpec.scala
Show resolved
Hide resolved
negokaz
reviewed
Oct 27, 2022
src/main/scala/lerna/akka/entityreplication/raft/snapshot/SnapshotStore.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares for #174
Add the following method and its unit test:
SnapshotStore$.persistenceId: returns a persistence ID ofSnapshotStoreAdd the following unit tests:
SnapshotStoreshould save the givenEntitySnapshot.SnapshotStoreshould save nothing if it has the sameEntitySnapshot.SnapshotStoreshould reply toFetchSnapshoteven if it is saving anEntitySnapshot.SnapshotStoreshould log a warning if it is saving anEntitySnapshotand receives aSaveSnapshotcommand.Change the following unit tests:
ShardSnapshotStoreFailureSpecgive a persistence ID toSnapshotTestKitfor clarifying the persistence ID to fail.