Add deprecated annotation to untyped APIs #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tksugimoto
force-pushed
the
untyped-api-is-deprecated
branch
from
48786b2 to
025c51c
Compare
…lassic API) Because it is used internally. ClusterReplicationSetting is always used with ClusterReplication, so there is no problem without deprecated annotation.
tksugimoto
force-pushed
the
untyped-api-is-deprecated
branch
from
025c51c to
11bdd76
Compare
Because it is a test of deprecated API
tksugimoto
force-pushed
the
untyped-api-is-deprecated
branch
from
11bdd76 to
4ceaaa8
Compare
tksugimoto
previously approved these changes
Jul 15, 2021
negokaz
commented
Jul 15, 2021
src/multi-jvm/scala/lerna/akka/entityreplication/ConsistencyTestBase.scala
Outdated
Show resolved
Hide resolved
- Easy to understand - Unrelated warnings are not ignored
tksugimoto
previously approved these changes
Jul 15, 2021
negokaz
commented
Jul 15, 2021
…nstead of deprecated apply method
tksugimoto
previously approved these changes
Jul 15, 2021
tksugimoto
changed the title
tksugimoto
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.