Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed instructions for setting parameters from a table #274

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

edwardalee
Copy link
Contributor

@edwardalee edwardalee commented Jul 7, 2024

This addresses this comment about duplicate symbols error occurring when following website instructions to initialize parameters from a table.

The Python version of this fix relies on PR 2353 in lingua-franca.

I have updated the version 0.8 docs for the C target only because the Python fix above is not in version 0.8 and the Python code works, albeit inefficiently. The C code, however, does not compile in version 0.8, so it needed to be fixed.

@edwardalee edwardalee added bug Something isn't working documentation Improvements or additions to documentation labels Jul 7, 2024
@edwardalee edwardalee requested a review from lhstrh July 7, 2024 11:38
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also make this change for the 0.8.0 docs.

@edwardalee
Copy link
Contributor Author

We should also make this change for the 0.8.0 docs.

Done with 68f692f

@edwardalee edwardalee requested a review from lhstrh July 8, 2024 11:21
@edwardalee edwardalee merged commit 606e363 into main Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants