-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic LF code formatter #1227
Conversation
All tests compile after being parsed and regurgitated.
Horizontal whitespace, vertical whitespace, removal of empty target config.
Co-authored-by: Marten Lohstroh <[email protected]>
String-based line-wrapping for formatter
Can we try to merge this soon? I promise that the change I just made was trivial and that this has mostly just been awaiting review for 23 days. |
Sorry, this was not on my radar as my review wasn't requested. I'll have a look at this soon. I agree, we should get this merged... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and almost ready to merge! 🚀 🚀 🚀 I left a few comments. The formatting of the tests looks excellent to me, modulo a single bike shedding issue: semicolons. I believe it makes sense to enforce them in the LF code if the target requires them, and I recall @edwardalee expressing the same preference.
This is necessary to format the Arduino tests.
These changes will be a separate PR.
Tasks:
.lf
files in thetest
directory and checks for equivalence (@lhstrh)org.lflang.lfc
toorg.lflang.cli
- @billy-baolff
package and createlff
application that applies formatter - @billy-baoFedGenerator
(to be submitted in a separate PR)