Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename org.lflang.lfc to org.lflang.cli #1235

Merged
merged 7 commits into from
Jun 16, 2022
Merged

Rename org.lflang.lfc to org.lflang.cli #1235

merged 7 commits into from
Jun 16, 2022

Conversation

billy-bao
Copy link
Collaborator

@billy-bao billy-bao commented Jun 15, 2022

This change is to simplify the addition of other command-line tools in the future, such as lfd (diagram generator) and lff (formatter). The previous Main class of lfc is renamed to org.lflang.cli.Lfc. Part of #1227.

@billy-bao billy-bao changed the base branch from master to pretty-printer June 15, 2022 23:15
@billy-bao billy-bao requested a review from lhstrh June 16, 2022 01:08
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great!


shadowJar {
archiveClassifier.set('lfc')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@lhstrh
Copy link
Member

lhstrh commented Jun 16, 2022

Thanks for this PR, @billy-bao! I'll go ahead and merge this since tests currently aren't passing in the pretty-printer branch either. I couldn't spot any problems. Great work!

@lhstrh lhstrh merged commit 3c314c6 into pretty-printer Jun 16, 2022
@lhstrh lhstrh deleted the lfc-to-cli branch June 16, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants