-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerShell scripts for lfc and lff #1430
Conversation
Right now, launch.ps1 will, just like how lfc and lff (which are symbolic links) on *NIX works, get the name of the invoker and run the corresponding jar file, which is not as PowerShell-y. We can use arguments like outlined here: https://stackoverflow.com/a/43940404. Nevertheless, it appears it does work somehow.
There appears to be some misunderstanding until I saw this: #1422 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! While testing this I noticed one problem though. It seems like we cannot pass any additional arguments to lfc and lff anymore. For instance .\bin\lfc.ps1 -c test\C\src\Minimal.lf
produces an error complaining that test\C\src\Minimal.lf
does not exist. Do you have an idea what is going on here? It works perfectly fine without any additional arguments.
Ah I see, powershell parsing error…… I always forget that powershell pass arguments as “objects” not strings! |
Unsure if using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for fixing this :-)
Thanks @axmmisaka! |
As mentioned in the commit message, this current implementation is very *NIX-y/bashy and not powershell-y. While I don‘t doubt its correctness this adds complications; maybe we should just pass the thing in as argument.