Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in error handling for Docker builds #2249

Merged
merged 5 commits into from
Apr 1, 2024

Commits on Mar 24, 2024

  1. Fix docker error handling.

    We were always returning false for whether errors occurred in federated
    docker builds, but we should be checking the context to see whether an
    error was reported.
    petervdonovan committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    fae5b1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9fff2a7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f540df3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c9fca22 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Fix another unrelated bug uncovered by testing fix

    Note how non-obvious it is that this is a bug or even why the fix works.
    This is a consequence of reliance on implicit reliance on big chunks of
    shared mutable state. The resource is modified; the context is
    computed from the resource; therefore, the resource has to be modified
    before the context is computed.
    petervdonovan committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    9296f07 View commit details
    Browse the repository at this point in the history