Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carla intersection refactoring #982

Merged
merged 23 commits into from
Mar 5, 2022
Merged

Carla intersection refactoring #982

merged 23 commits into from
Mar 5, 2022

Conversation

housengw
Copy link
Contributor

@housengw housengw commented Feb 25, 2022 •
edited
Loading

Refactored the intersection example to allow for more effective comparison between the implementation in LF and ROS.

Both implementations now uses the same underlying vehicle, rsu and carla simulator logic.

@housengw housengw changed the title Carla intersection add delay Carla intersection refactoring Feb 25, 2022
@housengw housengw marked this pull request as ready for review March 1, 2022 00:06
@housengw housengw requested a review from Soroosh129 March 1, 2022 00:06
Soroosh129
Soroosh129 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@Soroosh129 Soroosh129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactoring greatly improves our ability to do a proper A/B testing. The changes look great!

@housengw housengw merged commit f4c638f into carla-intersection-updates Mar 5, 2022
@housengw housengw deleted the carla-intersection-add-delay branch March 10, 2022 23:49
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh added the refactoring Code quality enhancement label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soroosh129 Soroosh129 Soroosh129 approved these changes

Assignees
No one assigned
Labels
refactoring Code quality enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@housengw @Soroosh129 @lhstrh