Optimization of value pointers for trivially copyable types #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Aug 22, 2022
Specifically, this includes the following PRs: - lf-lang/reactor-cpp#22 - lf-lang/reactor-cpp#23
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Aug 22, 2022
Specifically, this includes the following PRs: - lf-lang/reactor-cpp#22 - lf-lang/reactor-cpp#23
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Aug 22, 2022
Specifically, this includes the following PRs: - lf-lang/reactor-cpp#22 - lf-lang/reactor-cpp#23
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Aug 23, 2022
Specifically, this includes the following PRs: - lf-lang/reactor-cpp#22 - lf-lang/reactor-cpp#23
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Aug 23, 2022
Specifically, this includes the following PRs: - lf-lang/reactor-cpp#22 - lf-lang/reactor-cpp#23
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent optimization (#17) optimized the value pointers used by the runtime for scalar types. This avoids additional memory allocations. Experiments based on the Savina Benchmarks showed that there is potential to also reduce overhead for small structs and similar types. This PR applies the same optimization as in #17 to a wider range of types. Namely all that are trivially copyable and smaller smaller than 65 bytes. This threshold is arbitrarily chosen and we need to do more experimentation to select a good value.